r7376 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r7375‎ | r7376 | r7377 >
Date:05:51, 6 February 2005
Author:vibber
Status:old
Tags:
Comment:
* (bug 1477) hide details of SQL error messages by default
Set $wgShowSQLErrors = true for debugging.

Removed unused settings $wgBufferSQLResults and $wgShowSQLErrors.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/SpecialSitesettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialSitesettings.php
@@ -170,7 +170,6 @@
171171 $this->checkbox( 'wgDebugComments' ) .
172172 $this->checkbox( 'wgLogQueries' ) .
173173 $this->checkbox( 'wgDebugDumpSql' ) .
174 - $this->checkbox( 'wgIgnoreSQLErrors' ) .
175174 $this->fieldset( 'sitesettings-debugging-profiling',
176175 $this->checkbox( 'wgProfiling' ) .
177176 $this->textbox( 'wgProfileLimit' ) .
Index: trunk/phase3/includes/DefaultSettings.php
@@ -286,9 +286,6 @@
287287 $wgDBmysql4 = false;
288288 $wgSqlTimeout = 30;
289289
290 -/** use buffered queries by default */
291 -$wgBufferSQLResults = true;
292 -
293290 /**
294291 * Other wikis on this site, can be administered from a single developer
295292 * account.
@@ -414,9 +411,12 @@
415412 $wgLogQueries = false;
416413 $wgDebugDumpSql = false;
417414
418 -/** Whether to disable automatic generation of "we're sorry, but there has been
419 - * a database error" pages. */
420 -$wgIgnoreSQLErrors = false;
 415+/**
 416+ * Whether to show "we're sorry, but there has been a database error" pages.
 417+ * Displaying errors aids in debugging, but may display information useful
 418+ * to an attacker.
 419+ */
 420+$wgShowSQLErrors = false;
421421
422422 # Should [[Category:Dog]] on a page associate it with the
423423 # category "Dog"? (a link to that category page will be

Follow-up revisions

RevisionCommit summaryAuthorDate
r7377* (bug 1477) hide details of SQL error messages by default...vibber06:33, 6 February 2005

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r7375* (bug 1477) hide details of SQL error messages by default...vibber05:47, 6 February 2005

Status & tagging log