Re: [GIT PULL] vboxsf fixes for 5.14-1

Thread information [Search the linux-kernel archive]

 Hans de Goede
 ` Linus Torvalds
   ` Al Viro
     ` Al Viro
       ` Randy Dunlap
         ` Al Viro
           ` Randy Dunlap
     ` Rafał Miłecki
       ` Christoph Hellwig
       ` Greg KH
         ` Rafał Miłecki
           ` Matthew Wilcox
             ` Rafał Miłecki
               ` Neal Gompa
               ` Leonidas P. Papadakos
                 ` Linus Torvalds [this message]
                   ` Konstantin Komarov
                     ` Paragon NTFSv3 (was Re: [GIT PULL] vboxsf fixes for 5.14-1) Linus Torvalds
                       ` Konstantin Komarov
                         ` Stephen Rothwell
                         ` Kari Argillander
                       ` Linus Torvalds
                   ` [GIT PULL] vboxsf fixes for 5.14-1 Theodore Ts'o
                     ` Matthew Wilcox
                       ` Theodore Ts'o
                         ` Linus Torvalds
                           ` Theodore Ts'o
                             ` Darrick J. Wong
                               ` Kari Argillander
                                 ` Theodore Ts'o
                               ` Konstantin Komarov
                                 ` Darrick J. Wong
                           ` NTFS testing (was: " Szabolcs Szakacsits
                             ` Eric Biggers
                               ` Szabolcs Szakacsits
                 ` Pali Rohár
           ` Darrick J. Wong
             ` Christoph Hellwig
               ` Gao Xiang
               ` Eric W. Biederman
               ` Darrick J. Wong
 ` pr-tracker-bot

From:		Linus Torvalds <torvalds-AT-linux-foundation.org>
To:		"Leonidas P. Papadakos" <papadakospan-AT-gmail.com>, Konstantin Komarov <almaz.alexandrovich-AT-paragon-software.com>
Subject:		Re: [GIT PULL] vboxsf fixes for 5.14-1
Date:		Fri, 16 Jul 2021 11:07:29 -0700
Message-ID:		<CAHk-=whfeq9gyPWK3yao6cCj7LKeU3vQEDGJ3rKDdcaPNVMQzQ@mail.gmail.com>
Cc:		zajec5-AT-gmail.com, "Darrick J. Wong" <djwong-AT-kernel.org>, Greg Kroah-Hartman <gregkh-AT-linuxfoundation.org>, Hans de Goede <hdegoede-AT-redhat.com>, linux-fsdevel <linux-fsdevel-AT-vger.kernel.org>, Linux Kernel Mailing List <linux-kernel-AT-vger.kernel.org>, Al Viro <viro-AT-zeniv.linux.org.uk>, Matthew Wilcox <willy-AT-infradead.org>

On Fri, Jul 16, 2021 at 4:49 AM Leonidas P. Papadakos
<papadakospan@gmail.com> wrote:
>
> This driver is already in a much better feature state than the old ntfs driver from 2001.

If the new ntfs code has acks from people - and it sounds like it did
get them - and Paragon is expected to be the maintainer of it, then I
think Paragon should just make a git pull request for it.

That's assuming that it continues to be all in just fs/ntfs3/ (plus
fs/Kconfig, fs/Makefile and MAINTAINERS entries and whatever
documentation) and there are no other system-wide changes. Which I
don't think it had.

We simply don't have anybody to funnel new filesystems - the fsdevel
mailing list is good for comments and get feedback, but at some point
somebody just needs to actually submit it, and that's not what fsdevel
ends up doing.

The argument that "it's already in a much better state than the old
ntfs driver" may not be a very strong technical argument (not because
of any Paragon problems - just because the old ntfs driver is not
great), but it _is_ a fairly strong argument for merging the new one
from Paragon.

And I don't think there has been any huge _complaints_ about the code,
and I don't think there's been any sign that being outside the kernel
helps.

               Linus